From 51bc1873747adcadb873748d28781109ae97187c Mon Sep 17 00:00:00 2001
From: Froidefond Julien <julienfroidefond@gmail.com>
Date: Tue, 24 Feb 2026 17:12:46 +0100
Subject: [PATCH] fix: convert Map to Record for server-client boundary, remove
 dead currentUser prop

- WeatherBoard: change previousEntries type from Map<string, PreviousEntry> to Record<string, PreviousEntry> and update lookup from .get() to bracket notation
- page.tsx: wrap previousEntries with Object.fromEntries() before passing as prop, remove unused currentUser prop
- WeatherCard: remove spurious eslint-disable-next-line comment for non-existent rule react-hooks/set-state-in-effect

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 src/app/weather/[id]/page.tsx           | 7 +------
 src/components/weather/WeatherBoard.tsx | 9 ++-------
 src/components/weather/WeatherCard.tsx  | 1 -
 3 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/src/app/weather/[id]/page.tsx b/src/app/weather/[id]/page.tsx
index 7af13bb..a28f328 100644
--- a/src/app/weather/[id]/page.tsx
+++ b/src/app/weather/[id]/page.tsx
@@ -93,11 +93,6 @@ export default async function WeatherSessionPage({ params }: WeatherSessionPageP
         <WeatherBoard
           sessionId={session.id}
           currentUserId={authSession.user.id}
-          currentUser={{
-            id: authSession.user.id,
-            name: authSession.user.name ?? null,
-            email: authSession.user.email ?? '',
-          }}
           entries={session.entries}
           shares={session.shares}
           owner={{
@@ -106,7 +101,7 @@ export default async function WeatherSessionPage({ params }: WeatherSessionPageP
             email: session.user.email ?? '',
           }}
           canEdit={session.canEdit}
-          previousEntries={previousEntries}
+          previousEntries={Object.fromEntries(previousEntries)}
         />
       </WeatherLiveWrapper>
     </main>
diff --git a/src/components/weather/WeatherBoard.tsx b/src/components/weather/WeatherBoard.tsx
index 9cae558..7a9710a 100644
--- a/src/components/weather/WeatherBoard.tsx
+++ b/src/components/weather/WeatherBoard.tsx
@@ -38,11 +38,6 @@ type PreviousEntry = {
 interface WeatherBoardProps {
   sessionId: string;
   currentUserId: string;
-  currentUser: {
-    id: string;
-    name: string | null;
-    email: string;
-  };
   entries: WeatherEntry[];
   shares: Share[];
   owner: {
@@ -51,7 +46,7 @@ interface WeatherBoardProps {
     email: string;
   };
   canEdit: boolean;
-  previousEntries: Map<string, PreviousEntry>;
+  previousEntries: Record<string, PreviousEntry>;
 }
 
 export function WeatherBoard({
@@ -146,7 +141,7 @@ export function WeatherBoard({
               currentUserId={currentUserId}
               entry={entry}
               canEdit={canEdit}
-              previousEntry={previousEntries.get(entry.userId) ?? null}
+              previousEntry={previousEntries[entry.userId] ?? null}
             />
           ))}
         </tbody>
diff --git a/src/components/weather/WeatherCard.tsx b/src/components/weather/WeatherCard.tsx
index 630fd53..2b30012 100644
--- a/src/components/weather/WeatherCard.tsx
+++ b/src/components/weather/WeatherCard.tsx
@@ -69,7 +69,6 @@ export function WeatherCard({ sessionId, currentUserId, entry, canEdit, previous
 
   // Sync local state with props when they change (e.g., from SSE refresh)
   useEffect(() => {
-    // eslint-disable-next-line react-hooks/set-state-in-effect
     setNotes(entry.notes || '');
     setPerformanceEmoji(entry.performanceEmoji || null);
     setMoralEmoji(entry.moralEmoji || null);