feat: integrate UserPreferencesContext for improved preference management

- Added `UserPreferencesProvider` to `RootLayout` for centralized user preferences handling. - Updated components to remove direct user preferences fetching, relying on context instead. - Enhanced SSR data fetching by consolidating user preferences retrieval into a single service call. - Cleaned up unused props in various components to streamline the codebase.
2025-09-21 15:03:19 +02:00
parent 4ba6ba2c0b
commit c650c67627
17 changed files with 86 additions and 138 deletions
--- a/src/app/kanban/KanbanPageClient.tsx
+++ b/src/app/kanban/KanbanPageClient.tsx
@@ -4,8 +4,8 @@ import { useState } from 'react';
 import { KanbanBoardContainer } from '@/components/kanban/BoardContainer';
 import { Header } from '@/components/ui/Header';
 import { TasksProvider, useTasksContext } from '@/contexts/TasksContext';
-import { UserPreferencesProvider, useUserPreferences } from '@/contexts/UserPreferencesContext';
-import { Task, Tag, UserPreferences } from '@/lib/types';
+import { useUserPreferences } from '@/contexts/UserPreferencesContext';
+import { Task, Tag } from '@/lib/types';
 import { CreateTaskData } from '@/clients/tasks-client';
 import { CreateTaskForm } from '@/components/forms/CreateTaskForm';
 import { Button } from '@/components/ui/Button';
@@ -15,7 +15,6 @@ import { FontSizeToggle } from '@/components/ui/FontSizeToggle';
 interface KanbanPageClientProps {
  initialTasks: Task[];
  initialTags: (Tag & { usage: number })[];
-  initialPreferences: UserPreferences;
 }

 function KanbanPageContent() {
@@ -179,15 +178,13 @@ function KanbanPageContent() {
  );
 }

-export function KanbanPageClient({ initialTasks, initialTags, initialPreferences }: KanbanPageClientProps) {
+export function KanbanPageClient({ initialTasks, initialTags }: KanbanPageClientProps) {
  return (
-    <UserPreferencesProvider initialPreferences={initialPreferences}>
-      <TasksProvider 
-        initialTasks={initialTasks}
-        initialTags={initialTags}
-      >
-        <KanbanPageContent />
-      </TasksProvider>
-    </UserPreferencesProvider>
+    <TasksProvider 
+      initialTasks={initialTasks}
+      initialTags={initialTags}
+    >
+      <KanbanPageContent />
+    </TasksProvider>
  );
 }
--- a/src/app/kanban/page.tsx
+++ b/src/app/kanban/page.tsx
@@ -1,6 +1,5 @@
 import { tasksService } from '@/services/tasks';
 import { tagsService } from '@/services/tags';
-import { userPreferencesService } from '@/services/user-preferences';
 import { KanbanPageClient } from './KanbanPageClient';

 // Force dynamic rendering (no static generation)
@@ -8,17 +7,15 @@ export const dynamic = 'force-dynamic';

 export default async function KanbanPage() {
  // SSR - Récupération des données côté serveur
-  const [initialTasks, initialTags, initialPreferences] = await Promise.all([
+  const [initialTasks, initialTags] = await Promise.all([
    tasksService.getTasks(),
-    tagsService.getTags(),
-    userPreferencesService.getAllPreferences()
+    tagsService.getTags()
  ]);

  return (
    <KanbanPageClient 
      initialTasks={initialTasks}
      initialTags={initialTags}
-      initialPreferences={initialPreferences}
    />
  );
 }
--- a/src/app/layout.tsx
+++ b/src/app/layout.tsx
@@ -3,6 +3,7 @@ import { Geist, Geist_Mono } from "next/font/google";
 import "./globals.css";
 import { ThemeProvider } from "@/contexts/ThemeContext";
 import { JiraConfigProvider } from "@/contexts/JiraConfigContext";
+import { UserPreferencesProvider } from "@/contexts/UserPreferencesContext";
 import { userPreferencesService } from "@/services/user-preferences";

 const geistSans = Geist({
@@ -25,20 +26,19 @@ export default async function RootLayout({
 }: Readonly<{
  children: React.ReactNode;
 }>) {
-  // Récupérer les données côté serveur pour le SSR
-  const [initialTheme, jiraConfig] = await Promise.all([
-    userPreferencesService.getTheme(),
-    userPreferencesService.getJiraConfig()
-  ]);
+  // Récupérer toutes les préférences côté serveur pour le SSR
+  const initialPreferences = await userPreferencesService.getAllPreferences();
  
  return (
-    <html lang="en" className={initialTheme}>
+    <html lang="en" className={initialPreferences.viewPreferences.theme}>
      <body
        className={`${geistSans.variable} ${geistMono.variable} antialiased`}
      >
-        <ThemeProvider initialTheme={initialTheme}>
-          <JiraConfigProvider config={jiraConfig}>
-            {children}
+        <ThemeProvider initialTheme={initialPreferences.viewPreferences.theme}>
+          <JiraConfigProvider config={initialPreferences.jiraConfig}>
+            <UserPreferencesProvider initialPreferences={initialPreferences}>
+              {children}
+            </UserPreferencesProvider>
          </JiraConfigProvider>
        </ThemeProvider>
      </body>
--- a/src/app/page.tsx
+++ b/src/app/page.tsx
@@ -1,6 +1,5 @@
 import { tasksService } from '@/services/tasks';
 import { tagsService } from '@/services/tags';
-import { userPreferencesService } from '@/services/user-preferences';
 import { HomePageClient } from '@/components/HomePageClient';

 // Force dynamic rendering (no static generation)
@@ -8,10 +7,9 @@ export const dynamic = 'force-dynamic';

 export default async function HomePage() {
  // SSR - Récupération des données côté serveur
-  const [initialTasks, initialTags, initialPreferences, initialStats] = await Promise.all([
+  const [initialTasks, initialTags, initialStats] = await Promise.all([
    tasksService.getTasks(),
    tagsService.getTags(),
-    userPreferencesService.getAllPreferences(),
    tasksService.getTaskStats()
  ]);

@@ -19,7 +17,6 @@ export default async function HomePage() {
    <HomePageClient 
      initialTasks={initialTasks}
      initialTags={initialTags}
-      initialPreferences={initialPreferences}
      initialStats={initialStats}
    />
  );
--- a/src/app/settings/advanced/page.tsx
+++ b/src/app/settings/advanced/page.tsx
@@ -1,4 +1,3 @@
-import { userPreferencesService } from '@/services/user-preferences';
 import { tasksService } from '@/services/tasks';
 import { tagsService } from '@/services/tags';
 import { backupService } from '@/services/backup';
@@ -10,8 +9,7 @@ export const dynamic = 'force-dynamic';

 export default async function AdvancedSettingsPage() {
  // Fetch all data server-side
-  const [preferences, taskStats, tags] = await Promise.all([
-    userPreferencesService.getAllPreferences(),
+  const [taskStats, tags] = await Promise.all([
    tasksService.getTaskStats(),
    tagsService.getTags()
  ]);
@@ -38,7 +36,6 @@ export default async function AdvancedSettingsPage() {

  return (
    <AdvancedSettingsPageClient 
-      initialPreferences={preferences}
      initialDbStats={dbStats}
      initialBackupData={backupData}
    />
--- a/src/app/settings/general/page.tsx
+++ b/src/app/settings/general/page.tsx
@@ -1,4 +1,3 @@
-import { userPreferencesService } from '@/services/user-preferences';
 import { tagsService } from '@/services/tags';
 import { GeneralSettingsPageClient } from '@/components/settings/GeneralSettingsPageClient';

@@ -7,10 +6,7 @@ export const dynamic = 'force-dynamic';

 export default async function GeneralSettingsPage() {
  // Fetch data server-side
-  const [preferences, tags] = await Promise.all([
-    userPreferencesService.getAllPreferences(),
-    tagsService.getTags()
-  ]);
+  const tags = await tagsService.getTags();

-  return <GeneralSettingsPageClient initialPreferences={preferences} initialTags={tags} />;
+  return <GeneralSettingsPageClient initialTags={tags} />;
 }
--- a/src/app/settings/integrations/page.tsx
+++ b/src/app/settings/integrations/page.tsx
@@ -6,12 +6,11 @@ export const dynamic = 'force-dynamic';

 export default async function IntegrationsSettingsPage() {
  // Fetch data server-side
-  const preferences = await userPreferencesService.getAllPreferences();
+  // Preferences are now available via context
  const jiraConfig = await userPreferencesService.getJiraConfig();

  return (
    <IntegrationsSettingsPageClient 
-      initialPreferences={preferences}
      initialJiraConfig={jiraConfig}
    />
  );
--- a/src/app/settings/page.tsx
+++ b/src/app/settings/page.tsx
@@ -1,4 +1,3 @@
-import { userPreferencesService } from '@/services/user-preferences';
 import { SystemInfoService } from '@/services/system-info';
 import { SettingsIndexPageClient } from '@/components/settings/SettingsIndexPageClient';

@@ -7,14 +6,10 @@ export const dynamic = 'force-dynamic';

 export default async function SettingsPage() {
  // Fetch data in parallel for better performance
-  const [preferences, systemInfo] = await Promise.all([
-    userPreferencesService.getAllPreferences(),
-    SystemInfoService.getSystemInfo()
-  ]);
+  const systemInfo = await SystemInfoService.getSystemInfo();
  
  return (
    <SettingsIndexPageClient 
-      initialPreferences={preferences} 
      initialSystemInfo={systemInfo}
    />
  );
--- a/src/app/weekly-manager/WeeklyManagerPageClient.tsx
+++ b/src/app/weekly-manager/WeeklyManagerPageClient.tsx
@@ -1,32 +1,27 @@
 'use client';

 import { TasksProvider } from '@/contexts/TasksContext';
-import { UserPreferencesProvider } from '@/contexts/UserPreferencesContext';
 import ManagerWeeklySummary from '@/components/dashboard/ManagerWeeklySummary';
 import { ManagerSummary } from '@/services/manager-summary';
-import { Task, Tag, UserPreferences } from '@/lib/types';
+import { Task, Tag } from '@/lib/types';

 interface WeeklyManagerPageClientProps {
  initialSummary: ManagerSummary;
  initialTasks: Task[];
  initialTags: (Tag & { usage: number })[];
-  initialPreferences: UserPreferences;
 }

 export function WeeklyManagerPageClient({ 
  initialSummary, 
  initialTasks, 
-  initialTags, 
-  initialPreferences 
+  initialTags
 }: WeeklyManagerPageClientProps) {
  return (
-    <UserPreferencesProvider initialPreferences={initialPreferences}>
-      <TasksProvider 
-        initialTasks={initialTasks}
-        initialTags={initialTags}
-      >
-        <ManagerWeeklySummary initialSummary={initialSummary} />
-      </TasksProvider>
-    </UserPreferencesProvider>
+    <TasksProvider 
+      initialTasks={initialTasks}
+      initialTags={initialTags}
+    >
+      <ManagerWeeklySummary initialSummary={initialSummary} />
+    </TasksProvider>
  );
 }
--- a/src/app/weekly-manager/page.tsx
+++ b/src/app/weekly-manager/page.tsx
@@ -2,7 +2,6 @@ import { Header } from '@/components/ui/Header';
 import { ManagerSummaryService } from '@/services/manager-summary';
 import { tasksService } from '@/services/tasks';
 import { tagsService } from '@/services/tags';
-import { userPreferencesService } from '@/services/user-preferences';
 import { WeeklyManagerPageClient } from './WeeklyManagerPageClient';

 // Force dynamic rendering (no static generation)
@@ -10,11 +9,10 @@ export const dynamic = 'force-dynamic';

 export default async function WeeklyManagerPage() {
  // SSR - Récupération des données côté serveur
-  const [summary, initialTasks, initialTags, initialPreferences] = await Promise.all([
+  const [summary, initialTasks, initialTags] = await Promise.all([
    ManagerSummaryService.getManagerSummary(),
    tasksService.getTasks(),
-    tagsService.getTags(),
-    userPreferencesService.getAllPreferences()
+    tagsService.getTags()
  ]);

  return (
@@ -27,7 +25,6 @@ export default async function WeeklyManagerPage() {
            initialSummary={summary}
            initialTasks={initialTasks}
            initialTags={initialTags}
-            initialPreferences={initialPreferences}
          />
        </div>
      </div>