From 6fccf205816167bc031ec2f05e802babeaf75a24 Mon Sep 17 00:00:00 2001 From: Julien Froidefond Date: Fri, 26 Sep 2025 14:00:41 +0200 Subject: [PATCH] fix: clean up FilterBar title and improve useJiraFilters dependencies - Simplified the title prop in `FilterBar` for better readability. - Updated dependency array in `useJiraFilters` to include `filterAnalyticsLocally`, ensuring proper effect execution. - Added new line at the end of `test-jira-fields.ts` and `test-story-points.ts` for consistency. --- scripts/test-jira-fields.ts | 1 + scripts/test-story-points.ts | 1 + src/components/jira/FilterBar.tsx | 11 +---------- src/hooks/useJiraFilters.ts | 4 ++-- 4 files changed, 5 insertions(+), 12 deletions(-) diff --git a/scripts/test-jira-fields.ts b/scripts/test-jira-fields.ts index 9b37d71..11be27d 100644 --- a/scripts/test-jira-fields.ts +++ b/scripts/test-jira-fields.ts @@ -80,3 +80,4 @@ async function testJiraFields() { // Exécution du script testJiraFields().catch(console.error); + diff --git a/scripts/test-story-points.ts b/scripts/test-story-points.ts index 390b314..28ec586 100644 --- a/scripts/test-story-points.ts +++ b/scripts/test-story-points.ts @@ -106,3 +106,4 @@ async function testStoryPoints() { // Exécution du script testStoryPoints().catch(console.error); + diff --git a/src/components/jira/FilterBar.tsx b/src/components/jira/FilterBar.tsx index a424e35..d171b8f 100644 --- a/src/components/jira/FilterBar.tsx +++ b/src/components/jira/FilterBar.tsx @@ -183,16 +183,7 @@ export default function FilterBar({ setShowModal(false)} - title={ -
- Configuration des filtres - {isLoading && ( - - ⏳ Chargement... - - )} -
- } + title="Configuration des filtres" size="lg" >
diff --git a/src/hooks/useJiraFilters.ts b/src/hooks/useJiraFilters.ts index 2ba566f..a0b9b1b 100644 --- a/src/hooks/useJiraFilters.ts +++ b/src/hooks/useJiraFilters.ts @@ -1,5 +1,5 @@ import { useState, useEffect, useCallback } from 'react'; -import { getAvailableJiraFilters, getFilteredJiraAnalytics } from '@/actions/jira-filters'; +import { getAvailableJiraFilters } from '@/actions/jira-filters'; import { AvailableFilters, JiraAnalyticsFilters, JiraAnalytics } from '@/lib/types'; import { JiraAdvancedFiltersService } from '@/services/integrations/jira/advanced-filters'; @@ -171,7 +171,7 @@ export function useJiraFilters(initialAnalytics?: JiraAnalytics | null) { const filteredAnalytics = filterAnalyticsLocally(initialAnalytics, filters); setFilteredAnalytics(filteredAnalytics); } - }, [initialAnalytics]); + }, [initialAnalytics, filterAnalyticsLocally]); // Effacer tous les filtres const clearFilters = useCallback(() => {