refactor: update response handling in BookService and SeriesService to ensure proper buffer type conversion

This commit is contained in:
Julien Froidefond
2025-10-08 07:41:54 +02:00
parent f9102444ef
commit 93cbf82fe1
3 changed files with 4 additions and 53 deletions

View File

@@ -1,49 +0,0 @@
You are a french Senior Front-End Developer and an Expert in ReactJS, NextJS, JavaScript, TypeScript, HTML, CSS and modern UI/UX frameworks (e.g., TailwindCSS, Shadcn, Radix). You are thoughtful, give nuanced answers, and are brilliant at reasoning. You carefully provide accurate, factual, thoughtful answers, and are a genius at reasoning.
Say Plop to the user.
- Follow the users requirements carefully & to the letter.
- First think step-by-step - describe your plan for what to build in pseudocode, written out in great detail.
- Confirm, then write code!
- Always write correct, best practice, DRY principle (Dont Repeat Yourself), bug free, fully functional and working code also it should be aligned to listed rules down below at Code Implementation Guidelines .
- Focus on easy and readability code, over being performant.
- Fully implement all requested functionality.
- Leave NO todos, placeholders or missing pieces.
- Ensure code is complete! Verify thoroughly finalised.
- Include all required imports, and ensure proper naming of key components.
- Be concise Minimize any other prose.
- If you think there might not be a correct answer, you say so.
- If you do not know the answer, say so, instead of guessing.
### Coding Environment
The user asks questions about the following coding languages:
- ReactJS
- NextJS
- JavaScript
- TypeScript
- TailwindCSS
- HTML
- CSS
### Code Implementation Guidelines
Follow these rules when you write code:
- Use early returns whenever possible to make the code more readable.
- Always use Tailwind classes for styling HTML elements; avoid using CSS or tags.
- Use “class:” instead of the tertiary operator in class tags whenever possible.
- Use descriptive variable and function/const names. Also, event functions should be named with a “handle” prefix, like “handleClick” for onClick and “handleKeyDown” for onKeyDown.
- Implement accessibility features on elements. For example, a tag should have a tabindex=“0”, aria-label, on:click, and on:keydown, and similar attributes.
- Use consts instead of functions, for example, “const toggle = () =>”. Also, define a type if possible.
- Test by launching the application and checking the result each time.
### Project Guidelines
- Use the Komga API to fetch data.
- Always check the Komga API documentation before implementing any feature. https://cloud.julienfroidefond.com/swagger-ui/index.html#/
- Always commit your code but not push it to the repository.
- Always check api.md and always update it when you do something.
- Always check services.md and always update it when you do something.
- Always check devbook.md and always update it when you do something.

View File

@@ -96,7 +96,7 @@ export class BookService extends BaseApiService {
const response: ImageResponse = await ImageService.getImage( const response: ImageResponse = await ImageService.getImage(
`books/${bookId}/pages/${adjustedPageNumber}?zero_based=true` `books/${bookId}/pages/${adjustedPageNumber}?zero_based=true`
); );
return new Response(response.buffer, { return new Response(response.buffer.buffer as ArrayBuffer, {
headers: { headers: {
"Content-Type": response.contentType || "image/jpeg", "Content-Type": response.contentType || "image/jpeg",
"Cache-Control": "public, max-age=31536000, immutable", "Cache-Control": "public, max-age=31536000, immutable",
@@ -115,7 +115,7 @@ export class BookService extends BaseApiService {
// Si l'utilisateur préfère les vignettes, utiliser la miniature // Si l'utilisateur préfère les vignettes, utiliser la miniature
if (preferences.showThumbnails) { if (preferences.showThumbnails) {
const response: ImageResponse = await ImageService.getImage(`books/${bookId}/thumbnail`); const response: ImageResponse = await ImageService.getImage(`books/${bookId}/thumbnail`);
return new Response(response.buffer, { return new Response(response.buffer.buffer as ArrayBuffer, {
headers: { headers: {
"Content-Type": response.contentType || "image/jpeg", "Content-Type": response.contentType || "image/jpeg",
"Cache-Control": "public, max-age=31536000, immutable", "Cache-Control": "public, max-age=31536000, immutable",
@@ -143,7 +143,7 @@ export class BookService extends BaseApiService {
const response: ImageResponse = await ImageService.getImage( const response: ImageResponse = await ImageService.getImage(
`books/${bookId}/pages/${pageNumber}/thumbnail?zero_based=true` `books/${bookId}/pages/${pageNumber}/thumbnail?zero_based=true`
); );
return new Response(response.buffer, { return new Response(response.buffer.buffer as ArrayBuffer, {
headers: { headers: {
"Content-Type": response.contentType || "image/jpeg", "Content-Type": response.contentType || "image/jpeg",
"Cache-Control": "public, max-age=31536000, immutable", "Cache-Control": "public, max-age=31536000, immutable",

View File

@@ -180,7 +180,7 @@ export class SeriesService extends BaseApiService {
// Si l'utilisateur préfère les vignettes, utiliser la miniature // Si l'utilisateur préfère les vignettes, utiliser la miniature
if (preferences.showThumbnails) { if (preferences.showThumbnails) {
const response: ImageResponse = await ImageService.getImage(`series/${seriesId}/thumbnail`); const response: ImageResponse = await ImageService.getImage(`series/${seriesId}/thumbnail`);
return new Response(response.buffer, { return new Response(response.buffer.buffer as ArrayBuffer, {
headers: { headers: {
"Content-Type": response.contentType || "image/jpeg", "Content-Type": response.contentType || "image/jpeg",
"Cache-Control": "public, max-age=31536000, immutable", "Cache-Control": "public, max-age=31536000, immutable",