refactor: streamline ClientLayout and PreferencesContext for improved state management and debugging

This commit is contained in:
Julien Froidefond
2025-10-24 17:17:35 +02:00
parent 58cabd9cf2
commit 931185f0f0
7 changed files with 63 additions and 33 deletions

View File

@@ -1,7 +1,7 @@
"use client";
import { ThemeProvider } from "next-themes";
import { useState, useEffect, useMemo, useCallback } from "react";
import { useState, useEffect, useMemo, useCallback, useRef } from "react";
import { Header } from "@/components/layout/Header";
import { Sidebar } from "@/components/layout/Sidebar";
import { InstallPWA } from "../ui/InstallPWA";
@@ -28,17 +28,35 @@ export default function ClientLayout({ children, initialLibraries = [], initialF
const [randomBookId, setRandomBookId] = useState<string | null>(null);
const pathname = usePathname();
const { preferences } = usePreferences();
const prevLibraryIdsRef = useRef<string>("");
const backgroundType = preferences.background.type;
const komgaLibraries = preferences.background.komgaLibraries;
// Debug: log renders
useEffect(() => {
console.log('🎨 [ClientLayout] Render:', {
pathname,
backgroundType,
hasLibraries: !!komgaLibraries?.length,
preferencesKeys: Object.keys(preferences)
});
});
// Stabiliser libraryIds - ne change que si le contenu change vraiment
const libraryIdsString = useMemo(() => {
const newIds = komgaLibraries?.join(",") || "";
if (newIds !== prevLibraryIdsRef.current) {
prevLibraryIdsRef.current = newIds;
}
return prevLibraryIdsRef.current;
}, [komgaLibraries]);
// Récupérer un book aléatoire pour le background
const fetchRandomBook = useCallback(async () => {
if (
preferences.background.type === "komga-random" &&
preferences.background.komgaLibraries &&
preferences.background.komgaLibraries.length > 0
) {
if (backgroundType === "komga-random" && libraryIdsString) {
try {
const libraryIds = preferences.background.komgaLibraries.join(",");
const response = await fetch(`/api/komga/random-book?libraryIds=${libraryIds}`);
const response = await fetch(`/api/komga/random-book?libraryIds=${libraryIdsString}`);
if (response.ok) {
const data = await response.json();
setRandomBookId(data.bookId);
@@ -47,11 +65,13 @@ export default function ClientLayout({ children, initialLibraries = [], initialF
console.error("Erreur lors de la récupération d'un book aléatoire:", error);
}
}
}, [preferences.background.type, preferences.background.komgaLibraries]);
}, [backgroundType, libraryIdsString]);
useEffect(() => {
fetchRandomBook();
}, [fetchRandomBook]);
if (backgroundType === "komga-random" && libraryIdsString) {
fetchRandomBook();
}
}, [backgroundType, libraryIdsString, fetchRandomBook]);
const backgroundStyle = useMemo(() => {
const bg = preferences.background;

View File

@@ -3,7 +3,7 @@
import { CoverClient } from "./cover-client";
import { ProgressBar } from "./progress-bar";
import type { BookCoverProps } from "./cover-utils";
import { getImageUrl } from "./cover-utils";
import { getImageUrl } from "@/lib/utils/image-url";
import { useImageUrl } from "@/hooks/useImageUrl";
import { ClientOfflineBookService } from "@/lib/services/client-offlinebook.service";
import { MarkAsReadButton } from "./mark-as-read-button";

View File

@@ -19,14 +19,3 @@ export interface BookCoverProps extends BaseCoverProps {
export interface SeriesCoverProps extends BaseCoverProps {
series: KomgaSeries;
}
/**
* Génère l'URL de base pour une image (sans cache version)
* Utilisez useImageUrl() dans les composants pour obtenir l'URL avec cache busting
*/
export function getImageUrl(type: "series" | "book", id: string) {
if (type === "series") {
return `/api/komga/images/series/${id}/thumbnail`;
}
return `/api/komga/images/books/${id}/thumbnail`;
}

View File

@@ -3,7 +3,7 @@
import { CoverClient } from "./cover-client";
import { ProgressBar } from "./progress-bar";
import type { SeriesCoverProps } from "./cover-utils";
import { getImageUrl } from "./cover-utils";
import { getImageUrl } from "@/lib/utils/image-url";
import { useImageUrl } from "@/hooks/useImageUrl";
export function SeriesCover({