From 8d6f8f4de7a8b7a0691eedf7016d17b83ec55cb3 Mon Sep 17 00:00:00 2001
From: Julien Froidefond <julien.froidefond@cdbdx.biz>
Date: Fri, 17 Oct 2025 10:47:36 +0200
Subject: [PATCH] feat: enhance image loading in CoverClient component with
 timeout handling and error management, update PreferencesContext to
 initialize loading state as false, and refine type casting in
 PreferencesService

---
 src/components/ui/cover-client.tsx      | 48 ++++++++++++++++++++-----
 src/contexts/PreferencesContext.tsx     |  2 +-
 src/lib/services/preferences.service.ts |  6 ++--
 3 files changed, 43 insertions(+), 13 deletions(-)

diff --git a/src/components/ui/cover-client.tsx b/src/components/ui/cover-client.tsx
index 682e308..21264a9 100644
--- a/src/components/ui/cover-client.tsx
+++ b/src/components/ui/cover-client.tsx
@@ -1,8 +1,7 @@
 "use client";
 
 import { ImageOff } from "lucide-react";
-import Image from "next/image";
-import { useState } from "react";
+import { useState, useEffect, useRef } from "react";
 import { cn } from "@/lib/utils";
 import { ImageLoader } from "@/components/ui/image-loader";
 
@@ -21,6 +20,38 @@ export const CoverClient = ({
 }: CoverClientProps) => {
   const [imageError, setImageError] = useState(false);
   const [isLoading, setIsLoading] = useState(true);
+  const timeoutRef = useRef<NodeJS.Timeout | null>(null);
+
+  // Timeout de sécurité : si l'image ne se charge pas en 10 secondes, on arrête le loading
+  useEffect(() => {
+    timeoutRef.current = setTimeout(() => {
+      if (isLoading) {
+        console.warn("Image loading timeout for:", imageUrl);
+        setIsLoading(false);
+      }
+    }, 10000);
+
+    return () => {
+      if (timeoutRef.current) {
+        clearTimeout(timeoutRef.current);
+      }
+    };
+  }, [imageUrl, isLoading]);
+
+  const handleLoad = () => {
+    if (timeoutRef.current) {
+      clearTimeout(timeoutRef.current);
+    }
+    setIsLoading(false);
+  };
+
+  const handleError = () => {
+    if (timeoutRef.current) {
+      clearTimeout(timeoutRef.current);
+    }
+    console.error("Image loading error for:", imageUrl);
+    setImageError(true);
+  };
 
   if (imageError) {
     return (
@@ -33,19 +64,18 @@ export const CoverClient = ({
   return (
     <div className="relative w-full h-full">
       <ImageLoader isLoading={isLoading} />
-      <Image
+      {/* eslint-disable-next-line @next/next/no-img-element */}
+      <img
         src={imageUrl}
         alt={alt}
-        fill
+        loading="lazy"
         className={cn(
-          "object-cover transition-opacity duration-300 rounded-lg",
+          "absolute inset-0 w-full h-full object-cover transition-opacity duration-300 rounded-lg",
           isCompleted && "opacity-50",
           className
         )}
-        onError={() => setImageError(true)}
-        onLoad={() => setIsLoading(false)}
-        loading="lazy"
-        unoptimized
+        onError={handleError}
+        onLoad={handleLoad}
       />
     </div>
   );
diff --git a/src/contexts/PreferencesContext.tsx b/src/contexts/PreferencesContext.tsx
index 65f7c07..9e9a8cb 100644
--- a/src/contexts/PreferencesContext.tsx
+++ b/src/contexts/PreferencesContext.tsx
@@ -24,7 +24,7 @@ export function PreferencesProvider({
   const [preferences, setPreferences] = useState<UserPreferences>(
     initialPreferences || defaultPreferences
   );
-  const [isLoading, setIsLoading] = useState(true);
+  const [isLoading, setIsLoading] = useState(false);
 
   const fetchPreferences = async () => {
     try {
diff --git a/src/lib/services/preferences.service.ts b/src/lib/services/preferences.service.ts
index d52733b..29e5671 100644
--- a/src/lib/services/preferences.service.ts
+++ b/src/lib/services/preferences.service.ts
@@ -33,7 +33,7 @@ export class PreferencesService {
         showOnlyUnread: preferences.showOnlyUnread,
         debug: preferences.debug,
         displayMode: preferences.displayMode as UserPreferences["displayMode"],
-        background: (preferences.background as Prisma.JsonValue) as BackgroundPreferences,
+        background: preferences.background as unknown as BackgroundPreferences,
       };
     } catch (error) {
       if (error instanceof AppError) {
@@ -65,7 +65,7 @@ export class PreferencesService {
           showOnlyUnread: preferences.showOnlyUnread ?? defaultPreferences.showOnlyUnread,
           debug: preferences.debug ?? defaultPreferences.debug,
           displayMode: preferences.displayMode ?? defaultPreferences.displayMode,
-          background: (preferences.background ?? defaultPreferences.background) as Prisma.InputJsonValue,
+          background: (preferences.background ?? defaultPreferences.background) as unknown as Prisma.InputJsonValue,
         },
       });
 
@@ -75,7 +75,7 @@ export class PreferencesService {
         showOnlyUnread: updatedPreferences.showOnlyUnread,
         debug: updatedPreferences.debug,
         displayMode: updatedPreferences.displayMode as UserPreferences["displayMode"],
-        background: (updatedPreferences.background as Prisma.JsonValue) as BackgroundPreferences,
+        background: updatedPreferences.background as unknown as BackgroundPreferences,
       };
     } catch (error) {
       if (error instanceof AppError) {