From 6a06e5a7d352c3956dbd71e8aa76ea4c1fb59f5a Mon Sep 17 00:00:00 2001 From: Julien Froidefond Date: Mon, 2 Mar 2026 21:20:47 +0100 Subject: [PATCH] fix: disable service worker by default in production --- src/i18n/messages/en/common.json | 2 +- src/i18n/messages/fr/common.json | 2 +- src/lib/registerSW.ts | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/i18n/messages/en/common.json b/src/i18n/messages/en/common.json index 83139f1..cca5c1d 100644 --- a/src/i18n/messages/en/common.json +++ b/src/i18n/messages/en/common.json @@ -164,7 +164,7 @@ "reinstallError": "Error reinstalling Service Worker", "devServiceWorker": { "label": "Service Worker", - "description": "Enable or disable the Service Worker. Defaults: disabled in dev, enabled in prod. A reload is applied.", + "description": "Enable or disable the Service Worker. Defaults: disabled in dev and prod. A reload is applied.", "saved": "Service Worker preference updated", "error": "Failed to update Service Worker preference" }, diff --git a/src/i18n/messages/fr/common.json b/src/i18n/messages/fr/common.json index f144651..1f9b159 100644 --- a/src/i18n/messages/fr/common.json +++ b/src/i18n/messages/fr/common.json @@ -164,7 +164,7 @@ "reinstallError": "Erreur lors de la réinstallation du Service Worker", "devServiceWorker": { "label": "Service Worker", - "description": "Active ou désactive le Service Worker. Par défaut : désactivé en dev, activé en prod. Un rechargement est appliqué.", + "description": "Active ou désactive le Service Worker. Par défaut : désactivé en dev et en prod. Un rechargement est appliqué.", "saved": "Préférence Service Worker mise à jour", "error": "Impossible de mettre à jour la préférence Service Worker" }, diff --git a/src/lib/registerSW.ts b/src/lib/registerSW.ts index 335a902..bb4a347 100644 --- a/src/lib/registerSW.ts +++ b/src/lib/registerSW.ts @@ -20,7 +20,8 @@ export const isServiceWorkerEnabledInDev = (): boolean => { if (legacyValue === "true") return true; if (legacyValue === "false") return false; - return process.env.NODE_ENV !== "development"; + // Disabled by default in all environments; user preference can override. + return false; }; export const setServiceWorkerEnabledInDev = (enabled: boolean): void => {