feat: integrate CircuitBreakerService and adjust request timeout and queue management for improved API stability

This commit is contained in:
Julien Froidefond
2025-10-21 21:27:18 +02:00
parent ac62ba6d60
commit 66fbf98d54
3 changed files with 95 additions and 6 deletions

View File

@@ -8,6 +8,7 @@ import type { KomgaConfig } from "@/types/komga";
import type { ServerCacheService } from "./server-cache.service"; import type { ServerCacheService } from "./server-cache.service";
import { RequestMonitorService } from "./request-monitor.service"; import { RequestMonitorService } from "./request-monitor.service";
import { RequestQueueService } from "./request-queue.service"; import { RequestQueueService } from "./request-queue.service";
import { CircuitBreakerService } from "./circuit-breaker.service";
export type { CacheType }; export type { CacheType };
@@ -109,14 +110,16 @@ export abstract class BaseApiService {
} }
} }
// Timeout de 60 secondes au lieu de 10 par défaut // Timeout réduit à 15 secondes pour éviter les blocages longs
const timeoutMs = 60000; const timeoutMs = 15000;
const controller = new AbortController(); const controller = new AbortController();
const timeoutId = setTimeout(() => controller.abort(), timeoutMs); const timeoutId = setTimeout(() => controller.abort(), timeoutMs);
try { try {
// Utiliser le circuit breaker pour éviter de surcharger Komga
const response = await CircuitBreakerService.execute(async () => {
// Enqueue la requête pour limiter la concurrence // Enqueue la requête pour limiter la concurrence
const response = await RequestQueueService.enqueue(async () => { return await RequestQueueService.enqueue(async () => {
try { try {
return await fetch(url, { return await fetch(url, {
headers, headers,
@@ -167,6 +170,7 @@ export abstract class BaseApiService {
throw fetchError; throw fetchError;
} }
}); });
});
clearTimeout(timeoutId); clearTimeout(timeoutId);
if (!response.ok) { if (!response.ok) {

View File

@@ -0,0 +1,78 @@
/**
* Circuit Breaker pour éviter de surcharger Komga quand il est défaillant
* Évite l'effet avalanche en coupant les requêtes vers un service défaillant
*/
interface CircuitBreakerState {
state: 'CLOSED' | 'OPEN' | 'HALF_OPEN';
failureCount: number;
lastFailureTime: number;
nextAttemptTime: number;
}
class CircuitBreaker {
private state: CircuitBreakerState = {
state: 'CLOSED',
failureCount: 0,
lastFailureTime: 0,
nextAttemptTime: 0,
};
private readonly config = {
failureThreshold: 5, // Nombre d'échecs avant ouverture
recoveryTimeout: 30000, // 30s avant tentative de récupération
successThreshold: 3, // Nombre de succès pour fermer le circuit
};
async execute<T>(operation: () => Promise<T>): Promise<T> {
if (this.state.state === 'OPEN') {
if (Date.now() < this.state.nextAttemptTime) {
throw new Error('Circuit breaker is OPEN - Komga service unavailable');
}
this.state.state = 'HALF_OPEN';
}
try {
const result = await operation();
this.onSuccess();
return result;
} catch (error) {
this.onFailure();
throw error;
}
}
private onSuccess(): void {
if (this.state.state === 'HALF_OPEN') {
this.state.failureCount = 0;
this.state.state = 'CLOSED';
console.log('[CIRCUIT-BREAKER] ✅ Circuit closed - Komga recovered');
}
}
private onFailure(): void {
this.state.failureCount++;
this.state.lastFailureTime = Date.now();
if (this.state.failureCount >= this.config.failureThreshold) {
this.state.state = 'OPEN';
this.state.nextAttemptTime = Date.now() + this.config.recoveryTimeout;
console.warn(`[CIRCUIT-BREAKER] 🔴 Circuit OPEN - Komga failing (${this.state.failureCount} failures)`);
}
}
getState(): CircuitBreakerState {
return { ...this.state };
}
reset(): void {
this.state = {
state: 'CLOSED',
failureCount: 0,
lastFailureTime: 0,
nextAttemptTime: 0,
};
console.log('[CIRCUIT-BREAKER] 🔄 Circuit reset');
}
}
export const CircuitBreakerService = new CircuitBreaker();

View File

@@ -22,6 +22,12 @@ class RequestQueue {
async enqueue<T>(execute: () => Promise<T>): Promise<T> { async enqueue<T>(execute: () => Promise<T>): Promise<T> {
return new Promise<T>((resolve, reject) => { return new Promise<T>((resolve, reject) => {
// Limiter la taille de la queue pour éviter l'accumulation
if (this.queue.length >= 50) {
reject(new Error('Request queue is full - Komga may be overloaded'));
return;
}
this.queue.push({ execute, resolve, reject }); this.queue.push({ execute, resolve, reject });
this.processQueue(); this.processQueue();
}); });
@@ -45,8 +51,9 @@ class RequestQueue {
} }
try { try {
// Délai de 200ms entre chaque requête pour espacer la charge CPU sur Komga // Délai adaptatif : plus long si la queue est pleine
await this.delay(200); const delayMs = this.queue.length > 10 ? 500 : 200;
await this.delay(delayMs);
const result = await request.execute(); const result = await request.execute();
request.resolve(result); request.resolve(result);
} catch (error) { } catch (error) {