refacto: favorites error : final on sidebar

This commit is contained in:
Julien Froidefond
2025-02-26 10:37:13 +01:00
parent 94c75ac126
commit 1a0e4d2422

View File

@@ -7,6 +7,10 @@ import { authService } from "@/lib/services/auth.service";
import { useEffect, useState, useCallback } from "react"; import { useEffect, useState, useCallback } from "react";
import { KomgaLibrary, KomgaSeries } from "@/types/komga"; import { KomgaLibrary, KomgaSeries } from "@/types/komga";
import { usePreferences } from "@/contexts/PreferencesContext"; import { usePreferences } from "@/contexts/PreferencesContext";
import { AppError } from "@/utils/errors";
import { ERROR_CODES } from "@/constants/errorCodes";
import { ERROR_MESSAGES } from "@/constants/errorMessages";
import { useToast } from "@/components/ui/use-toast";
interface SidebarProps { interface SidebarProps {
isOpen: boolean; isOpen: boolean;
@@ -23,32 +27,37 @@ export function Sidebar({ isOpen, onClose }: SidebarProps) {
const [isRefreshing, setIsRefreshing] = useState(false); const [isRefreshing, setIsRefreshing] = useState(false);
const [isLoadingFavorites, setIsLoadingFavorites] = useState(true); const [isLoadingFavorites, setIsLoadingFavorites] = useState(true);
const { toast } = useToast();
const fetchLibraries = useCallback(async () => { const fetchLibraries = useCallback(async () => {
setIsLoading(true); setIsLoading(true);
try { try {
const response = await fetch("/api/komga/libraries"); const response = await fetch("/api/komga/libraries");
if (!response.ok) { if (!response.ok) {
throw new Error("Erreur lors de la récupération des bibliothèques"); throw new AppError(ERROR_CODES.LIBRARY.FETCH_ERROR);
} }
const data = await response.json(); const data = await response.json();
setLibraries(data); setLibraries(data);
} catch (error) { } catch (error) {
if (error instanceof Error) { console.error("Erreur de chargement des bibliothèques:", error);
console.error("Erreur de chargement des bibliothèques:", error.message); toast({
} title: "Erreur",
description: error instanceof AppError ? error.message : ERROR_MESSAGES[ERROR_CODES.LIBRARY.FETCH_ERROR],
variant: "destructive",
});
setLibraries([]); setLibraries([]);
} finally { } finally {
setIsLoading(false); setIsLoading(false);
setIsRefreshing(false); setIsRefreshing(false);
} }
}, []); }, [toast]);
const fetchFavorites = useCallback(async () => { const fetchFavorites = useCallback(async () => {
setIsLoadingFavorites(true); setIsLoadingFavorites(true);
try { try {
const favoritesResponse = await fetch("/api/komga/favorites"); const favoritesResponse = await fetch("/api/komga/favorites");
if (!favoritesResponse.ok) { if (!favoritesResponse.ok) {
throw new Error("Erreur lors de la récupération des favoris"); throw new AppError(ERROR_CODES.FAVORITE.FETCH_ERROR);
} }
const favoriteIds = await favoritesResponse.json(); const favoriteIds = await favoritesResponse.json();
@@ -59,21 +68,26 @@ export function Sidebar({ isOpen, onClose }: SidebarProps) {
const promises = favoriteIds.map(async (id: string) => { const promises = favoriteIds.map(async (id: string) => {
const response = await fetch(`/api/komga/series/${id}`); const response = await fetch(`/api/komga/series/${id}`);
if (!response.ok) return null; if (!response.ok) {
throw new AppError(ERROR_CODES.SERIES.FETCH_ERROR);
}
return response.json(); return response.json();
}); });
const results = await Promise.all(promises); const results = await Promise.all(promises);
setFavorites(results.filter((series): series is KomgaSeries => series !== null)); setFavorites(results.filter((series): series is KomgaSeries => series !== null));
} catch (error) { } catch (error) {
if (error instanceof Error) { console.error("Erreur de chargement des favoris:", error);
console.error("Erreur de chargement des favoris:", error.message); toast({
} title: "Erreur",
description: error instanceof AppError ? error.message : ERROR_MESSAGES[ERROR_CODES.FAVORITE.FETCH_ERROR],
variant: "destructive",
});
setFavorites([]); setFavorites([]);
} finally { } finally {
setIsLoadingFavorites(false); setIsLoadingFavorites(false);
} }
}, []); }, [toast]);
// Chargement initial des données // Chargement initial des données
useEffect(() => { useEffect(() => {
@@ -106,11 +120,20 @@ export function Sidebar({ isOpen, onClose }: SidebarProps) {
}; };
const handleLogout = async () => { const handleLogout = async () => {
await authService.logout(); try {
setLibraries([]); await authService.logout();
setFavorites([]); setLibraries([]);
onClose(); setFavorites([]);
router.push("/login"); onClose();
router.push("/login");
} catch (error) {
console.error("Erreur lors de la déconnexion:", error);
toast({
title: "Erreur",
description: error instanceof AppError ? error.message : ERROR_MESSAGES[ERROR_CODES.AUTH.LOGOUT_ERROR],
variant: "destructive",
});
}
}; };
const handleLinkClick = useCallback( const handleLinkClick = useCallback(