From 3e119813cd31a77d11d09f34dff5b33cc7b26fa7 Mon Sep 17 00:00:00 2001
From: Julien Froidefond <julien.froidefond@cdbdx.biz>
Date: Mon, 8 Dec 2025 07:51:30 +0100
Subject: [PATCH] refactor: simplify Check component rendering in
 CategoryCombobox for improved readability and maintainability

---
 components/ui/category-combobox.tsx | 27 +++++++++------------------
 1 file changed, 9 insertions(+), 18 deletions(-)

diff --git a/components/ui/category-combobox.tsx b/components/ui/category-combobox.tsx
index 752c5e8..49479a4 100644
--- a/components/ui/category-combobox.tsx
+++ b/components/ui/category-combobox.tsx
@@ -206,12 +206,9 @@ export function CategoryCombobox({
               <CommandItem value="__none__" onSelect={() => handleSelect(null)}>
                 <X className="h-4 w-4 text-muted-foreground" />
                 <span className="text-muted-foreground">Aucune catégorie</span>
-                <Check
-                  className={cn(
-                    "ml-auto h-4 w-4",
-                    value === null ? "opacity-100" : "opacity-0",
-                  )}
-                />
+                {value === null && (
+                  <Check className="ml-auto h-4 w-4" />
+                )}
               </CommandItem>
             </CommandGroup>
             <CommandGroup>
@@ -227,12 +224,9 @@ export function CategoryCombobox({
                       size={16}
                     />
                     <span className="font-medium">{parent.name}</span>
-                    <Check
-                      className={cn(
-                        "ml-auto h-4 w-4",
-                        value === parent.id ? "opacity-100" : "opacity-0",
-                      )}
-                    />
+                    {value === parent.id && (
+                      <Check className="ml-auto h-4 w-4" />
+                    )}
                   </CommandItem>
                   {childrenByParent[parent.id]?.map((child) => (
                     <CommandItem
@@ -247,12 +241,9 @@ export function CategoryCombobox({
                         size={16}
                       />
                       <span>{child.name}</span>
-                      <Check
-                        className={cn(
-                          "ml-auto h-4 w-4",
-                          value === child.id ? "opacity-100" : "opacity-0",
-                        )}
-                      />
+                      {value === child.id && (
+                        <Check className="ml-auto h-4 w-4" />
+                      )}
                     </CommandItem>
                   ))}
                 </div>